Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable clasifier filter #189

Merged
merged 13 commits into from
Apr 1, 2021
Merged

disable clasifier filter #189

merged 13 commits into from
Apr 1, 2021

Conversation

aerlaut
Copy link
Contributor

@aerlaut aerlaut commented Mar 31, 2021

Background

Link to issue

https://biomage.atlassian.net/secure/RapidBoard.jspa?rapidView=1&selectedIssue=BIOMAGE-736

Link to staging deployment URL

https://ui-agi-ui189-api80.scp-staging.biomage.net/

Links to any Pull Requests related to this

hms-dbmi-cellenics/api#80

Anything else the reviewers should know about the changes here

  • Disabled on the UI and update classifier filter enabled to false if preFiltered is detected as true in sample.
  • New disabled message if caused by prefiltered sample.
  • Added new action to load samples : loadSamples

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@aerlaut aerlaut merged commit 98687de into master Apr 1, 2021
@aerlaut aerlaut deleted the flag-disable-classifier-filter branch April 1, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants