[BIOMAGE-1109] Fix metadata not saving (#329)

* Remove no longer used sample ids and remove properties that aren't samples from the updates * Remove samples extra loading * Fix tsts * Fix
hms-dbmi-cellenics · Jun 14, 2021 · df1da93 · df1da93
1 parent db0f619
commit df1da93
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 9 deletions.
diff --git a/src/__test__/redux/reducers/__snapshots__/samplesReducer.test.js.snap b/src/__test__/redux/reducers/__snapshots__/samplesReducer.test.js.snap
@@ -171,7 +171,6 @@ Object {
     "asd123",
     "qwe234",
   ],
-  "loading": false,
   "meta": Object {
     "error": false,
     "loading": false,

diff --git a/src/redux/actions/projects/createMetadataTrack.js b/src/redux/actions/projects/createMetadataTrack.js
@@ -36,7 +36,9 @@ const createMetadataTrack = (
       },
     });
 
-    await Promise.all(Object.entries(samples).map(([sampleUuid, sample]) => dispatch({
+    const { meta, loading, ...onlySamples } = samples;
+
+    await Promise.all(Object.entries(onlySamples).map(([sampleUuid, sample]) => dispatch({
       type: SAMPLES_UPDATE,
       payload: {
         sampleUuid,

diff --git a/src/redux/actions/projects/deleteMetadataTrack.js b/src/redux/actions/projects/deleteMetadataTrack.js
@@ -31,9 +31,7 @@ const deleteMetadataTrack = (
       ...curr,
       [sampleUuid]: updatedSample,
     };
-  }, {
-    ids: project.samples,
-  });
+  }, {});
 
   try {
     await dispatch(saveProject(projectUuid, newProject, false));

diff --git a/src/redux/actions/projects/updateMetadataTrack.js b/src/redux/actions/projects/updateMetadataTrack.js
@@ -37,9 +37,7 @@ const updateMetadataTrack = (
       ...curr,
       [sampleUuid]: updatedSample,
     };
-  }, {
-    ids: project.samples,
-  });
+  }, {});
 
   try {
     await dispatch(saveProject(projectUuid, newProject, false));

diff --git a/src/redux/reducers/samples/samplesLoaded.js b/src/redux/reducers/samples/samplesLoaded.js
@@ -2,7 +2,6 @@ const samplesLoad = (state, action) => {
   const { samples } = action.payload;
   return {
     ...state,
-    loading: false,
     meta: {
       ...state.meta,
       loading: false,