Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to R 4.4.0 #363

Merged
merged 31 commits into from
May 23, 2024
Merged

update to R 4.4.0 #363

merged 31 commits into from
May 23, 2024

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Mar 15, 2024

Description

  • updates R to 4.4.0 and all packages
  • updates code for Seurat V5 (current)

Things tested:

  • Default pipeline with 10x dataset
  • "within" and "between" DE with 10x and Seurat datasets
  • All integration methods with 10x dataset
  • ScType automated clustering with new 10x dataset
  • leiden clustering with new 10x dataset
  • Upload of Seurat object with Assay5 RNA
  • trajectory analysis with new 10x dataset

staging:

https://ui-alex-worker357-pipeline363.staging.single-cell-platform.net

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

hms-dbmi-cellenics/worker#357

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

Signed-off-by: Alex Pickering <[email protected]>
@alexvpickering alexvpickering added the safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source. label Mar 15, 2024
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
@alexvpickering alexvpickering changed the title update to R 4.3.3 update to R 4.4.0 May 14, 2024
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Copy link
Member

@gerbeldo gerbeldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, left some comments and questions.

pipeline-runner/tests/testthat/test-qc.R Outdated Show resolved Hide resolved
pipeline-runner/Dockerfile Show resolved Hide resolved
pipeline-runner/.Rprofile Show resolved Hide resolved
Copy link
Member

@gerbeldo gerbeldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, left some comments and questions.

Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
@alexvpickering alexvpickering merged commit 4cec13d into master May 23, 2024
10 checks passed
@alexvpickering alexvpickering deleted the update-r-ver branch May 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants