Use latest renv version #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sara castellano <[email protected]>
saracastel
added
the
safe to run
gerbeldo
reviewed
Feb 29, 2024
pipeline-runner/Dockerfile
Outdated
| @@ -20,7 +20,7 @@ RUN echo ".libPaths(c('$RENV_LIB', .libPaths()))" >> $(R RHOME)/etc/Rprofile.sit | |||
|
|
|||
| # install renv to install required R packages | |||
| RUN R -q -e "install.packages('remotes', repos = c(CRAN = 'https://cloud.r-project.org'))" && \ | |||
| R -q -e "remotes::install_github('rstudio/renv@0.16.0')" && \ | |||
| R -q -e "remotes::install_github('rstudio/renv')" && \ | |||
There was a problem hiding this comment.
you should fix the version to latest here.
There was a problem hiding this comment.
be mindful that they changed the way they write versions. Now it's like "v1.0.5"
There was a problem hiding this comment.
Also, you will probably need to update the config files in the .renv directory
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
=======================================
Coverage 80.46% 80.46%
=======================================
Files 29 29
Lines 3087 3087
=======================================
Hits 2484 2484
Misses 603 603 ☔ View full report in Codecov by Sentry. |
added 3 commits
March 1, 2024 10:03
Signed-off-by: sara castellano <[email protected]>
…pgrade-renv Signed-off-by: sara castellano <[email protected]>
Signed-off-by: sara castellano <[email protected]>
alexvpickering
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change modifies the Dockerfile to install the latest version of
renvfrom GitHub instead of using a fixed version.This was done because the pipeline build was failing locally.
Details
URL to issue
N/A
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional