Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Seurat upload bug #359

Merged

Conversation

saracastel
Copy link
Contributor

@saracastel saracastel commented Feb 9, 2024

Description

Seurat upload fails if there are NAs in the metadata. This PR fixes this issue making sure that columns with NA values are not considered as candidates for cluster column. Metadata columns with NA values are still kept and visible as metadata values in the platform.

Staging: https://ui-sara-pipeline15.scp-staging.biomage.net/

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

Signed-off-by: sara castellano <[email protected]>
@alexvpickering alexvpickering added the safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source. label Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef2fae2) 80.45% compared to head (8d041ee) 80.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   80.45%   80.46%           
=======================================
  Files          29       29           
  Lines        3085     3086    +1     
=======================================
+ Hits         2482     2483    +1     
  Misses        603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alexvpickering alexvpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@saracastel saracastel merged commit 498b11a into hms-dbmi-cellenics:master Feb 16, 2024
13 checks passed
@saracastel saracastel deleted the biomage-fix-seurat-upload branch February 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants