Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust doublet score calculation according to sequencing technology #355

Merged
merged 17 commits into from
Jan 29, 2024

Conversation

saracastel
Copy link
Contributor

Description

Details

URL to issue

This PR addresses an issue where the existing method for calculating doublet scores tends to overestimate doublets in Parse datasets. This overestimation could lead to the unintended exclusion of high-quality cells. The root of this problem lies in the difference in expected doublet rates between Parse and 10x datasets, with Parse data generally having a lower rate.
To rectify this, the PR proposes an adjustment to the doublet score calculation specifically for Parse data. It involves modifying the dbr parameter in the scDblFinder function to align with the empirical doublet rates observed in a mixed species experiment conducted using Parse technology.

Note: the code has been prepared to modify the dbr value based on the specific Parse kit used. However, we have decided to maintain the value associated with the WT kit as the default for now. The reason for this decision is that implementing the UI component to input information about the Parse kit is not a priority at this moment.

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@saracastel saracastel added the safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source. label Jan 29, 2024
sara castellano added 4 commits January 29, 2024 11:27
Signed-off-by: sara castellano <[email protected]>
Signed-off-by: sara castellano <[email protected]>
…e into biomage-adjust-doublet-score

Signed-off-by: sara castellano <[email protected]>
Signed-off-by: sara castellano <[email protected]>
@saracastel saracastel merged commit dddacd0 into hms-dbmi-cellenics:master Jan 29, 2024
9 of 10 checks passed
@saracastel saracastel deleted the adjust-doublet-score branch January 29, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants