-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust doublet score calculation according to sequencing technology #355
Merged
saracastel
merged 17 commits into
hms-dbmi-cellenics:master
from
biomage-org:adjust-doublet-score
Jan 29, 2024
Merged
Adjust doublet score calculation according to sequencing technology #355
saracastel
merged 17 commits into
hms-dbmi-cellenics:master
from
biomage-org:adjust-doublet-score
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saracastel
added
the
safe to run
safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source.
label
Jan 29, 2024
10 tasks
Signed-off-by: sara castellano <[email protected]>
Signed-off-by: sara castellano <[email protected]>
…e into biomage-adjust-doublet-score Signed-off-by: sara castellano <[email protected]>
Signed-off-by: sara castellano <[email protected]>
gerbeldo
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
safe to run
safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details
URL to issue
This PR addresses an issue where the existing method for calculating doublet scores tends to overestimate doublets in Parse datasets. This overestimation could lead to the unintended exclusion of high-quality cells. The root of this problem lies in the difference in expected doublet rates between Parse and 10x datasets, with Parse data generally having a lower rate.
To rectify this, the PR proposes an adjustment to the doublet score calculation specifically for Parse data. It involves modifying the dbr parameter in the scDblFinder function to align with the empirical doublet rates observed in a mixed species experiment conducted using Parse technology.
Note: the code has been prepared to modify the dbr value based on the specific Parse kit used. However, we have decided to maintain the value associated with the WT kit as the default for now. The reason for this decision is that implementing the UI component to input information about the Parse kit is not a priority at this moment.
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional