exclude scDblFinder columns from Seurat uploads #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pickering <[email protected]>
alexvpickering
added
the
safe to run
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 80.33% 80.33%
=======================================
Files 29 29
Lines 3061 3062 +1
=======================================
+ Hits 2459 2460 +1
Misses 602 602 ☔ View full report in Codecov by Sentry. |
gerbeldo
approved these changes
Jan 23, 2024
|
|
||
| # exclude all group columns, including duplicates | ||
| group_cols <- find_group_columns([email protected], remove.dups = FALSE) | ||
| group_cols <- find_group_columns(meta, remove.dups = FALSE) | ||
| scdblfinder_cols <- grep('^scDblFinder', colnames(meta), value = TRUE) |
There was a problem hiding this comment.
why not add it to exclude_cols? don't really feel strongly about it though. whatever you think looks best is fine by me.
There was a problem hiding this comment.
That's what I did initially as well but it interferes with how exclude_cols is used further down (checking to see if a column is same as samples or other group column). I'll rename exclude_cols to make this more obvious
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Excludes columns that start with
scDblFinderfrom uploaded Seurat objectsDetails
URL to issue
hms-dbmi-cellenics/issues#107
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional