Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: genes v umi filter not using user-defined parameters #351

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

gerbeldo
Copy link
Member

@gerbeldo gerbeldo commented Jan 4, 2024

Description

The UI/API do not change the value of the p.level parameter sent in the config, but when auto is disabled, it adds a new predictionInterval parameter, which was not used at all in the pipeline, always defaulting to the auto estimated p.level value. Therefore changes to the filter did not produce the intended filtering.

This PR takes the predictionInterval parameter value and actually uses it to define the p.level parameter used by the predict function.

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@gerbeldo gerbeldo added the safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source. label Jan 4, 2024
Signed-off-by: German Beldorati Stark <[email protected]>
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (993ebc4) 80.33% compared to head (3368b7b) 80.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files          29       29           
  Lines        3061     3061           
=======================================
  Hits         2459     2459           
  Misses        602      602           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerbeldo gerbeldo merged commit 47aaa32 into hms-dbmi-cellenics:master Jan 4, 2024
13 checks passed
@gerbeldo gerbeldo deleted the hotfix-genes-v-umi branch January 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants