Handle duplicated barcodes #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sara castellano <[email protected]>
Signed-off-by: German Beldorati Stark <[email protected]>
gerbeldo
added
the
safe to run
Signed-off-by: German Beldorati Stark <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 79.86% 80.00% +0.14%
==========================================
Files 29 29
Lines 2970 2986 +16
==========================================
+ Hits 2372 2389 +17
+ Misses 598 597 -1
|
Signed-off-by: sara castellano <[email protected]>
3 tasks
ogibson
reviewed
Nov 6, 2023
| @@ -381,13 +386,21 @@ make_cl_metadata_cellclass <- function(variable, type, cl_metadata, color_pool) | |||
| values <- unique(cl_metadata[[variable]]) | |||
|
|
|||
| for (i in seq_along(values)) { | |||
|
|
|||
| cell_ids <- cl_metadata[get(variable) == values[i] & cl_metadata$duplicate_barcode == "no", cells_id] | |||
ogibson
reviewed
Nov 6, 2023
| @@ -381,13 +386,21 @@ make_cl_metadata_cellclass <- function(variable, type, cl_metadata, color_pool) | |||
| values <- unique(cl_metadata[[variable]]) | |||
|
|
|||
| for (i in seq_along(values)) { | |||
|
|
|||
| cell_ids <- cl_metadata[get(variable) == values[i] & cl_metadata$duplicate_barcode == "no", cells_id] | |||
There was a problem hiding this comment.
Check that duplicate_barcode exists
Signed-off-by: German Beldorati Stark <[email protected]>
Signed-off-by: German Beldorati Stark <[email protected]>
ogibson
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details
URL to issue
hms-dbmi-cellenics/issues#60
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional