Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install rgeos from archive #337

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

gerbeldo
Copy link
Member

Description

The pipeline build is failing due to rgeos being removed from CRAN. This PR installs it from the CRAN archive.

Additionally, when running renv::restore the dependency tree was fixed automatically, updating the extra dependencies.

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

Signed-off-by: German Beldorati Stark <[email protected]>
@gerbeldo gerbeldo added the safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source. label Oct 18, 2023
Signed-off-by: German Beldorati Stark <[email protected]>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #337 (7d20c24) into master (ad56718) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files          29       29           
  Lines        2871     2871           
=======================================
  Hits         2286     2286           
  Misses        585      585           

@gerbeldo gerbeldo enabled auto-merge October 18, 2023 18:04
@gerbeldo gerbeldo merged commit d189de8 into hms-dbmi-cellenics:master Oct 18, 2023
11 checks passed
@gerbeldo gerbeldo deleted the fix-pipeline-build branch October 18, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants