Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a whole-file default value for region #326

Merged

Conversation

kafkasl
Copy link
Contributor

@kafkasl kafkasl commented Aug 18, 2023

Description

Due to recent modifications to app.js setting up the AWS_DEFAULT_REGION env variable was required. The error was very obscure, because when creating the lambda function is uses a default with region: process.env.AWS_DEFAULT_REGION || 'eu-west-1'. However, when adding the variable to the template it does not (which is the latest addition) causing the pipeline to fail once it started.

I modified the code to set the default for the whole file instead of just for one of the cases.

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@kafkasl kafkasl requested a review from alexvpickering August 18, 2023 16:59
@alexvpickering alexvpickering added the safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source. label Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #326 (6492db7) into master (5345e5f) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files          29       29           
  Lines        2821     2821           
=======================================
  Hits         2244     2244           
  Misses        577      577           

@alexvpickering alexvpickering merged commit e4e39eb into hms-dbmi-cellenics:master Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to run safe to run Marks the PR as safe to run checks on. IMPORTANT only add if from a trusted source.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants