Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional datadog #301

Merged
merged 2 commits into from
Mar 29, 2023
Merged

conditional datadog #301

merged 2 commits into from
Mar 29, 2023

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Mar 29, 2023

Description

HMS deployment has no datadog

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

Signed-off-by: Alex Pickering <[email protected]>
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #301 (ae6f568) into master (3e82d35) will not change coverage.
The diff coverage is n/a.

❗ Current head ae6f568 differs from pull request most recent head ff7ad7a. Consider uploading reports for the commit ff7ad7a to get more accurate results

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   78.90%   78.90%           
=======================================
  Files          27       27           
  Lines        2574     2574           
=======================================
  Hits         2031     2031           
  Misses        543      543           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alexvpickering alexvpickering merged commit e8233df into master Mar 29, 2023
@alexvpickering alexvpickering deleted the biomage-changes-3 branch March 29, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant