[BIOMAGE-1864] added heartbeat to tasks #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 70.60% 70.60%
=======================================
Files 19 19
Lines 1446 1446
=======================================
Hits 1021 1021
Misses 425 425 Continue to review full report at Codecov.
|
9 tasks
gerbeldo
reviewed
Apr 15, 2022
Co-authored-by: german <[email protected]>
aerlaut
reviewed
Apr 18, 2022
| # | ||
| # Sends a heartbeat to the state machine every 10 seconds | ||
| # Once the task is completed the heartbeat will fail accordingly with a | ||
| # task timeout and exit the loop and a new heartbeat will be set up by next task. |
There was a problem hiding this comment.
The task timeout is 10800 seconds (3 hours). If the task succeeds, does this mean that this bg process will run for 3 hours before failing?
There was a problem hiding this comment.
no:
- as soon as the task is completed the heartbeat fails and the loop stops
- when a pipeline finishes the pod and everything running inside is just killed
aerlaut
reviewed
Apr 20, 2022
aerlaut
approved these changes
Apr 20, 2022
Co-authored-by: Anugerah Erlaut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added parallel processing to set up a heartbeat function that sends heartbeats to the state machines during the task processing.
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1846
Link to staging deployment URL (or set N/A)
https://ui-yes-heartbeat.scp-staging.biomage.net/
Links to any PRs or resources related to this PR
hms-dbmi-cellenics/api#333
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional