Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed cleanup operator role to cleanup-operator #186

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

kafkasl
Copy link
Contributor

@kafkasl kafkasl commented Nov 10, 2021

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-1550

Link to staging deployment URL

Links to any Pull Requests related to this

#186
hms-dbmi-cellenics/worker#212
hms-dbmi-cellenics/iac#202

Anything else the reviewers should know about the changes here

Removed worker & pipeline cleanup operators because it will because crashed pods will be handled by the API.

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging
  • Passed integration tests

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #186 (9ba2419) into master (7ebdb56) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   63.58%   63.58%           
=======================================
  Files          19       19           
  Lines        1318     1318           
=======================================
  Hits          838      838           
  Misses        480      480           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebdb56...9ba2419. Read the comment docs.

@kafkasl kafkasl marked this pull request as ready for review November 11, 2021 16:27
@kafkasl kafkasl merged commit 8505743 into master Nov 12, 2021
@kafkasl kafkasl deleted the event-exporter-role branch November 12, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants