Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth jwt added to error message pipeline fail #180

Merged
merged 26 commits into from
Nov 11, 2021
Merged

Conversation

StefanBabukov
Copy link
Member

Background

Added the jwt token on pipeline error response, so that the api can get user details from it

Link to issue

Link to staging deployment URL

Links to any Pull Requests related to this

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging
  • Passed integration tests

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #180 (8a79b1d) into master (e019c19) will increase coverage by 0.99%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   62.58%   63.58%   +0.99%     
==========================================
  Files          19       19              
  Lines        1315     1318       +3     
==========================================
+ Hits          823      838      +15     
+ Misses        492      480      -12     
Impacted Files Coverage Δ
pipeline-runner/R/qc-5-filter_doublets.R 90.47% <ø> (ø)
pipeline-runner/R/handle_data.R 7.53% <16.66%> (+7.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e019c19...8a79b1d. Read the comment docs.

@StefanBabukov StefanBabukov merged commit 7ebdb56 into master Nov 11, 2021
@StefanBabukov StefanBabukov deleted the add-authjwt branch November 11, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants