Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fix #18

merged 1 commit into from
Mar 24, 2021

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Mar 24, 2021

Background

Link to issue

Link to staging deployment URL

Links to any Pull Requests related to this

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

Copy link
Contributor

@aerlaut aerlaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosa65 cosa65 merged commit 8d0cf05 into master Mar 24, 2021
@cosa65 cosa65 deleted the quick_fix_generate_plot_uuid branch March 24, 2021 14:11
alexvpickering pushed a commit that referenced this pull request Jan 4, 2023
…-runner/ws-7.5.9

Bump ws from 7.4.3 to 7.5.9 in /local-runner
gerbeldo pushed a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants