Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-1494] - Add prefiltered flag to classifier #178

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

aerlaut
Copy link
Contributor

@aerlaut aerlaut commented Oct 7, 2021

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-1494

Link to staging deployment URL

In UI PR

Links to any Pull Requests related to this

UI - hms-dbmi-cellenics/ui#528
API - hms-dbmi-cellenics/api#242
Pipeline - #178
IAC Migration - hms-dbmi-cellenics/iac#191

Anything else the reviewers should know about the changes here

Changes

Code changes

  • Add prefiltered

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging
  • Passed integration tests

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #178 (0728317) into master (d1d1ed1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   56.72%   56.76%   +0.03%     
==========================================
  Files          19       19              
  Lines        1234     1235       +1     
==========================================
+ Hits          700      701       +1     
  Misses        534      534              
Impacted Files Coverage Δ
pipeline-runner/R/gem2s-6-construct_qc_config.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d1ed1...0728317. Read the comment docs.

@aerlaut aerlaut merged commit 1c02f3c into master Oct 8, 2021
@aerlaut aerlaut deleted the add-prefiltered-property branch October 8, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants