Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix knee plot in QC pipeline #15

Merged
merged 1 commit into from
Mar 22, 2021
Merged

fix knee plot in QC pipeline #15

merged 1 commit into from
Mar 22, 2021

Conversation

alexvpickering
Copy link
Contributor

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-673

Link to staging deployment URL

Links to any Pull Requests related to this

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@alexvpickering alexvpickering requested a review from ogibson March 22, 2021 23:22
Copy link
Contributor

@ogibson ogibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested on rstudio.

@alexvpickering alexvpickering requested review from cosa65 and removed request for cosa65 March 22, 2021 23:27
@alexvpickering alexvpickering merged commit 23b1f3f into master Mar 22, 2021
@alexvpickering alexvpickering deleted the knee-surgery branch March 22, 2021 23:30
alexvpickering pushed a commit that referenced this pull request Jan 4, 2023
…-runner/lodash-4.17.21

Bump lodash from 4.17.20 to 4.17.21 in /local-runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants