Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seurat upload #517

Merged
merged 11 commits into from
Nov 2, 2022
Merged

Seurat upload #517

merged 11 commits into from
Nov 2, 2022

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Sep 21, 2022

Background

Link to issue

Link to staging deployment URL

Links to any Pull Requests related to this

hms-dbmi-cellenics/ui#800
hms-dbmi-cellenics/api#411
hms-dbmi-cellenics/pipeline#285
hms-dbmi-cellenics/worker#294
#517

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/hms-dbmi-cellenics/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/hms-dbmi-cellenics/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@alexvpickering alexvpickering temporarily deployed to HMS October 26, 2022 16:26 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:05 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:09 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:09 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:28 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:28 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:29 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:31 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:32 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:36 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:37 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:37 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 17:37 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 18:22 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 18:22 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 18:23 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 18:23 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS October 28, 2022 18:23 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS November 1, 2022 16:41 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS November 2, 2022 17:43 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS November 2, 2022 17:43 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS November 2, 2022 17:44 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS November 2, 2022 17:44 Inactive
@alexvpickering alexvpickering temporarily deployed to HMS November 2, 2022 17:44 Inactive
@alexvpickering alexvpickering merged commit 5fe7493 into master Nov 2, 2022
@alexvpickering alexvpickering deleted the seurat-upload branch November 2, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant