Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report all completed steps #73

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

xverges
Copy link
Contributor

@xverges xverges commented Mar 24, 2021

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-669

Link to staging deployment URL

N/A

Links to any Pull Requests related to this

N/A

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@xverges xverges merged commit 1a8f01d into master Mar 24, 2021
@xverges xverges deleted the full-pipeline-state-reporting branch March 24, 2021 17:59
alexvpickering pushed a commit that referenced this pull request Jan 5, 2023
[BIOMAGE-2286] - add schema for downsampling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants