Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block UI based on pipeline state #62

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Mar 12, 2021

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-498

Link to staging deployment URL

https://ui-martin-ui144-api62.scp-staging.biomage.net/

Links to any Pull Requests related to this

hms-dbmi-cellenics/ui#144

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

…ipeline on the ui every time we need to know its status
@cosa65 cosa65 force-pushed the block_ui_based_on_pipeline_state branch from e351bae to 06dd848 Compare March 12, 2021 19:02
Comment on lines 45 to 47
console.log('messageDebug');
console.log(JSON.stringify(message));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need to go

@cosa65 cosa65 merged commit cab3d09 into master Mar 15, 2021
@cosa65 cosa65 deleted the block_ui_based_on_pipeline_state branch March 15, 2021 14:14
alexvpickering pushed a commit that referenced this pull request Jan 5, 2023
…e-uri-component-0.2.2

Bump decode-uri-component from 0.2.0 to 0.2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants