-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upload over 2 gb #524
Fix upload over 2 gb #524
Conversation
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
… don't require it anymore as a result of the removal Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
src/api.v2/helpers/s3/signedUrl.js
Outdated
const promises = []; | ||
const parts = Math.ceil(size / FILE_CHUNK_SIZE); | ||
|
||
for (let i = 0; i < parts; i += 1) { | ||
promises.push( | ||
s3.getSignedUrlPromise('uploadPart', { | ||
...baseParams, | ||
PartNumber: i + 1, | ||
}), | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we don't try to predict how many parts we'll send, we just send them whenever the read/compress stream makes them available and request a signed url for each of them. This request is managed with the new endpoint in uploadController
, which calls the new function getPartUploadSignedUrl
…'t really do anything else Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 90.11% 89.90% -0.22%
==========================================
Files 169 171 +2
Lines 3754 3765 +11
Branches 429 429
==========================================
+ Hits 3383 3385 +2
- Misses 348 354 +6
- Partials 23 26 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Signed-off-by: cosa65 <[email protected]>
Description
Details
URL to issue
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional