[Cell-level metadata] Update the Add metadata select

[StefanBabukov]

Description

Details

URL to issue

https://github.com/orgs/hms-dbmi-cellenics/projects/4/views/1?pane=issue&itemId=37286398

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

• Migrated any selector / reducer used to the new format.
• All new dependency licenses have been checked for compatibility

Manual/unit testing

• Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
• Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
• Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

• Started end-to-end tests on the latest commit.

Documentation updates

• Relevant Github READMEs updated or no GitHub README updates required.
• Relevant Wiki pages created/updated or no Wiki updates required.

Optional

• Staging environment is unstaged before merging.
• Photo of a cute animal attached to this PR.

[codecov]

Codecov Report

Merging #488 (c586e59) into master (92994ec) will decrease coverage by 0.65%.
The diff coverage is 65.51%.

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   90.50%   89.86%   -0.65%     
==========================================
  Files         160      166       +6     
  Lines        3498     3572      +74     
  Branches      390      395       +5     
==========================================
+ Hits         3166     3210      +44     
- Misses        311      340      +29     
- Partials       21       22       +1     

Files	Coverage Δ
src/api.v2/controllers/experimentController.js	98.62% <ø> (ø)
src/api.v2/controllers/sampleFileController.js	96.96% <100.00%> (-0.40%)	⬇️
src/api.v2/helpers/s3/signedUrl.js	100.00% <100.00%> (ø)
src/api.v2/model/CellLevelMeta.js	100.00% <100.00%> (ø)
src/api.v2/model/tableNames.js	100.00% <ø> (ø)
src/api.v2/routes/sampleFile.js	100.00% <ø> (ø)
src/api.v2/routes/s3Upload.js	66.66% <66.66%> (ø)
src/api.v2/model/CellLevelMetaToExperiment.js	71.42% <71.42%> (ø)
src/api.v2/routes/cellLevel.js	60.00% <60.00%> (ø)
src/api.v2/controllers/s3Upload.js	77.77% <77.77%> (ø)
... and 2 more

[cosa65]

There's some tests pending I think

[ivababukova]

@StefanBabukov wouldn't it be better to use the name cellLevelMeta instead of cellLevel? We are shortening the name with 4 chars, but I feel like we loose a lot of descriptiveness and adding 4 more chars is worth it?

[cosa65]

This call won't work, also we are allowing users to decide what to patch, and that's not something we want to do.

[cosa65]

This isn't part of the ticket anyways, so maybe you could just leave this function empty

[StefanBabukov]

I'm using this to update the status of the upload. What's the problem here? Why would it not work?

[cosa65]

I mean rather than snake casing anything that arrives, just extract the upload status and update only that.

It's more or less what the patch of sample files const patchFile = async (req, res) => { does

[cosa65]

lgtm, I think there was one comment to address from iva too