Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use batch by default in prod #432

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Apr 4, 2023

Description

don't use batch in prod by default

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.
  • All new dependency licenses have been checked for compatibility

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

Signed-off-by: Alex Pickering <[email protected]>
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #432 (5af64fb) into master (ab00c48) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files         155      155           
  Lines        3401     3401           
  Branches      377      377           
=======================================
  Hits         3086     3086           
  Misses        298      298           
  Partials       17       17           
Impacted Files Coverage Δ
src/api.v2/controllers/experimentController.js 96.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alexvpickering alexvpickering merged commit 458fa67 into master Apr 4, 2023
@alexvpickering alexvpickering deleted the default-not-batch branch April 4, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant