[BIOMAGE-2015] Removed dynamo references #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 86.75% 88.72% +1.97%
==========================================
Files 123 121 -2
Lines 2876 2724 -152
Branches 323 305 -18
==========================================
- Hits 2495 2417 -78
+ Misses 362 292 -70
+ Partials 19 15 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. |
cosa65
approved these changes
Jul 25, 2022
| @@ -41,7 +41,7 @@ const setupEnums = async (knex) => { | |||
| await knex.raw('CREATE TYPE sample_technology AS ENUM (\'10x\', \'rhapsody\');'); | |||
| await knex.raw('CREATE TYPE sample_file_type AS ENUM (\'features10x\', \'barcodes10x\', \'matrix10x\', \'rhapsody\');'); | |||
| await knex.raw( | |||
| 'CREATE TYPE upload_status AS ENUM (\'uploaded\', \'uploading\', \'compressing\', \'uploadError\', \'fileNotFound\', \'fileReadError\', \'fileReadAborted\');', | |||
| 'CREATE TYPE upload_status AS ENUM (\'invalidFormat\', \'uploaded\', \'uploading\', \'compressing\', \'uploadError\', \'fileNotFound\', \'fileReadError\', \'fileReadAborted\');', | |||
There was a problem hiding this comment.
I don't think we can do this change here, you need to add a new migration to add invalidFormat to the upload_status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup dynamo resources
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-2015
Link to staging deployment URL (or set N/A)
https://ui-ahriman-flabby-fox.scp-staging.biomage.net/
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional