-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BIOMAGE-1893] - Add migration to create sample delete trigger #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 167 167
Lines 4575 4575
Branches 487 487
=======================================
Hits 4060 4060
Misses 482 482
Partials 33 33 Continue to review full report at Codecov.
|
9 tasks
cosa65
reviewed
Jul 11, 2022
src/sql/migrations/20220704130411_add_delete_sample_file_trigger.js
Outdated
Show resolved
Hide resolved
src/sql/migrations/20220704130411_add_delete_sample_file_trigger.js
Outdated
Show resolved
Hide resolved
src/sql/migrations/20220704130411_add_delete_sample_file_trigger.js
Outdated
Show resolved
Hide resolved
src/sql/migrations/20220704130411_add_delete_sample_file_trigger.js
Outdated
Show resolved
Hide resolved
cosa65
reviewed
Jul 11, 2022
src/sql/migrations/20220704130411_add_delete_sample_file_trigger.js
Outdated
Show resolved
Hide resolved
src/sql/migrations/20220704130411_add_delete_sample_file_trigger.js
Outdated
Show resolved
Hide resolved
cosa65
approved these changes
Jul 12, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an RDS migration to create sample delete trigger, which triggers a lambda to delete sample file from S3 when a sample is deleted.
To test :
s3_path
in RDS (i.e. connect viapsql
or a GUI SQL editor). Take note of the path.Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1893
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional