Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-1997] Getting aws account ID from env #382

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Conversation

kafkasl
Copy link
Contributor

@kafkasl kafkasl commented Jul 1, 2022

Description

Instead of having to wait in async to retrieve the accountId from STS we can now just retrieve it from the pod environment variables making everything easier. Almost all changes are just tests (unifying the test account ID from test-account-id and our actual ID to 000000000)

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-1997

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@kafkasl kafkasl marked this pull request as ready for review July 1, 2022 09:41
@kafkasl kafkasl changed the title getting aws account ID from env [BIOMAGE-1997] Getting aws account ID from env Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #382 (dcab270) into master (95a6c3b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   88.72%   88.74%   +0.01%     
==========================================
  Files         167      167              
  Lines        4585     4575      -10     
  Branches      487      487              
==========================================
- Hits         4068     4060       -8     
+ Misses        484      482       -2     
  Partials       33       33              
Impacted Files Coverage Δ
src/api.v2/helpers/s3/bucketNames.js 100.00% <ø> (ø)
src/api/general-services/get-work-results.js 100.00% <ø> (ø)
src/config/test-config.js 100.00% <ø> (ø)
...api.v2/helpers/pipeline/pipelineConstruct/index.js 97.54% <100.00%> (ø)
src/api.v2/helpers/worker/workSubmit/index.js 61.40% <100.00%> (-0.67%) ⬇️
src/api.v2/model/Experiment.js 93.02% <100.00%> (ø)
src/api/general-services/pipeline-manage/index.js 97.41% <100.00%> (ø)
src/api/general-services/work-submit/index.js 61.40% <100.00%> (-0.67%) ⬇️
src/api/route-services/experiment.js 81.98% <100.00%> (ø)
src/api/route-services/plots-tables.js 80.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a6c3b...dcab270. Read the comment docs.

Copy link
Contributor

@aerlaut aerlaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comments.

src/api/general-services/pipeline-manage/index.js Outdated Show resolved Hide resolved
src/config/default-config.js Show resolved Hide resolved
@kafkasl kafkasl force-pushed the accountid-from-env branch from 524adf1 to 91ee795 Compare July 1, 2022 10:38
@kafkasl kafkasl enabled auto-merge July 1, 2022 11:54
@kafkasl kafkasl merged commit 52ee4ed into master Jul 1, 2022
@kafkasl kafkasl deleted the accountid-from-env branch July 1, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants