Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1635 Add example experiments creation #377

Merged
merged 32 commits into from
Jun 27, 2022

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Jun 21, 2022

Description

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-1635

Link to staging deployment URL (or set N/A)

https://ui-martinfosco-ui747-api377.scp-staging.biomage.net/

Links to any PRs or resources related to this PR

hms-dbmi-cellenics/ui#747

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #377 (9040c9a) into master (2a77a3f) will increase coverage by 0.05%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   88.65%   88.71%   +0.05%     
==========================================
  Files         167      167              
  Lines        4514     4580      +66     
  Branches      483      486       +3     
==========================================
+ Hits         4002     4063      +61     
- Misses        479      484       +5     
  Partials       33       33              
Impacted Files Coverage Δ
src/api.v2/helpers/roles.js 100.00% <ø> (ø)
src/api.v2/helpers/worker/getWorkResults.js 100.00% <ø> (ø)
tests/api.v2/mocks/getMockSqlClient.js 100.00% <ø> (ø)
src/api.v2/model/Experiment.js 93.02% <54.54%> (-5.70%) ⬇️
src/api.v2/controllers/experimentController.js 100.00% <100.00%> (ø)
src/api.v2/model/Sample.js 100.00% <100.00%> (ø)
src/api.v2/model/UserAccess.js 100.00% <100.00%> (ø)
src/api.v2/routes/experiment.js 93.33% <100.00%> (+1.02%) ⬆️
src/utils/constants.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a77a3f...9040c9a. Read the comment docs.

@cosa65 cosa65 force-pushed the 1635-add-example-experiments-creation branch from 9ee2d30 to 1c0ca31 Compare June 22, 2022 17:58
src/api.v2/model/Sample.js Outdated Show resolved Hide resolved
src/specs/api.v2.yaml Outdated Show resolved Hide resolved
src/api.v2/controllers/experimentController.js Outdated Show resolved Hide resolved
@cosa65 cosa65 merged commit 321acae into master Jun 27, 2022
@cosa65 cosa65 deleted the 1635-add-example-experiments-creation branch June 27, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants