Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix plots in v2 by adding handling for plots not existing before.
Some plots, like frequency and embedding, don't need
plotData
so we don't generate rows in the db for them until we need something to persist (some speicfic plot config changes that aren't default).We need to support then the
NotFoundError
triggering from thePlot
model (also we need to support upsert to create entries for the plots that have specific config changes but don't have a row in yet)Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1928
Link to staging deployment URL (or set N/A)
https://ui-martinfosco-api362.scp-staging.biomage.net/
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional