Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plots in v2 #362

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Jun 7, 2022

Description

Fix plots in v2 by adding handling for plots not existing before.

Some plots, like frequency and embedding, don't need plotData so we don't generate rows in the db for them until we need something to persist (some speicfic plot config changes that aren't default).

We need to support then the NotFoundError triggering from the Plot model (also we need to support upsert to create entries for the plots that have specific config changes but don't have a row in yet)

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-1928

Link to staging deployment URL (or set N/A)

https://ui-martinfosco-api362.scp-staging.biomage.net/

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #362 (0c25e0b) into master (e4fd20a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   87.73%   87.74%           
=======================================
  Files         166      166           
  Lines        4468     4471    +3     
  Branches      477      479    +2     
=======================================
+ Hits         3920     3923    +3     
  Misses        509      509           
  Partials       39       39           
Impacted Files Coverage Δ
...i.v2/helpers/pipeline/hooks/assignPodToPipeline.js 84.09% <ø> (-0.70%) ⬇️
src/api.v2/model/Plot.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69c0c5...0c25e0b. Read the comment docs.

@cosa65 cosa65 merged commit 624e66b into master Jun 8, 2022
@cosa65 cosa65 deleted the 1928-fix-api-plots-add-404-when-plot-is-not-found branch June 8, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants