Fix auth rds not refreshing after expiration #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.02%
==========================================
Files 137 137
Lines 3679 3678 -1
Branches 405 405
==========================================
Hits 3136 3136
+ Misses 500 499 -1
Partials 43 43
Continue to review full report at Codecov.
|
9 tasks
cosa65
changed the title
cosa65
commented
May 3, 2022
Comment on lines
+21
to
+27
| const fetchConfiguration = async (environment, rdsSandboxId) => ({ | ||
| [environment]: { | ||
| client: 'postgresql', | ||
| connection: async () => await getConnectionParams(environment, rdsSandboxId), | ||
| postProcessResponse: recursiveCamelcase, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This is the important change: don't call await of getConnectionParams, pass an async function that knex can await when necessary instead
ivababukova
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a problem with the knex connection refresh. It was not setup properly so when a connection expired knex couldn't really do anything about it, now it can call
connectionagain properly so it can refresh the db connection.This problem wasn't immediately noticed because we need to leave a staging up for a while to run into this issue
Details
URL to issue
N/A
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Only the api PR wil lget merged, the ui one was only to be able to test in staging
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional