[BIOMAGE-1747] Expired token

src/utils/authMiddlewares.js

@@ -153,11 +153,13 @@ const checkAuthExpiredMiddleware = (req, res, next) => {
  * Authentication middleware for Socket.IO requests. Resolves with
  * the JWT claim if the authentication was successful, or rejects with
  * the error otherwise.
+ * If ignoreExpiration is set to true, jwt.verify will not return an error
+ * for expired tokens.
  *
  * @param {*} authHeader The bearer-encoded JWT token.
  * @returns Promise that resolves or rejects based on authentication status.
  */
-const authenticationMiddlewareSocketIO = async (authHeader) => {
+const authenticationMiddlewareSocketIO = async (authHeader, ignoreExpiration = false) => {
   const poolId = await config.awsUserPoolIdPromise;
   const cache = CacheSingleton.get();
 
@@ -187,6 +189,7 @@ const authenticationMiddlewareSocketIO = async (authHeader) => {
         });
     },
     {
+      ignoreExpiration,
       algorithms: ['RS256'],
       issuer,
     },

src/utils/hooks/hookRunner.js

@@ -31,28 +31,36 @@ class hookRunner {
 
   // run requires taskName to be present as a key in the payload
   async run(payload) {
-    const { taskName } = payload;
-    this.results[taskName] = [];
+    // run all hooks inside a try catch because they are side-effects and as such, they should
+    // not break the main program execution
+    try {
+      const { taskName } = payload;
+      this.results[taskName] = [];
 
-    // Manual looping is done to prevent passing function in hooks[taskName] into a callback,
-    // which might cause scoping issues
+      // Manual looping is done to prevent passing function in hooks[taskName] into a callback,
+      // which might cause scoping issues
 
-    // Runs task specific hooks
-    for (let i = 0; this.hooks[taskName] !== undefined && i < this.hooks[taskName].length; i += 1) {
-      // calling the hooks sequentially since they may depend on each other
-      // eslint-disable-next-line no-await-in-loop
-      this.results[taskName].push(await this.hooks[taskName][i](payload));
-    }
+      // Runs task specific hooks
+      // eslint-disable-next-line max-len
+      for (let i = 0; this.hooks[taskName] !== undefined && i < this.hooks[taskName].length; i += 1) {
+        // calling the hooks sequentially since they may depend on each other
+        // eslint-disable-next-line no-await-in-loop
+        this.results[taskName].push(await this.hooks[taskName][i](payload));
+      }
 
-    // Runs hooks that apply to all tasks (assigning the results to current task)
-    for (let i = 0; this.hooks[ALL] !== undefined && i < this.hooks[ALL].length; i += 1) {
-      // eslint-disable-next-line no-await-in-loop
-      this.results[taskName].push(await this.hooks[ALL][i](payload));
-    }
+      // Runs hooks that apply to all tasks (assigning the results to current task)
+      for (let i = 0; this.hooks[ALL] !== undefined && i < this.hooks[ALL].length; i += 1) {
+        // eslint-disable-next-line no-await-in-loop
+        this.results[taskName].push(await this.hooks[ALL][i](payload));
+      }
 
-    logger.log(`Completed ${this.results[taskName].length} hooks for pipeline task ${taskName}`);
+      logger.log(`Completed ${this.results[taskName].length} hooks for pipeline task ${taskName}`);
 
-    return this.results;
+      return this.results;
+    } catch (e) {
+      logger.error('Error running hooks: ', e);
+    }
+    return [];
   }
 }
 

src/utils/hooks/send-notification.js

@@ -16,7 +16,8 @@ const sendNotification = async (message) => {
     logger.log('No authJWT token in message, skipping status check for notifications...');
     return;
   }
-  const user = await authenticationMiddlewareSocketIO(authJWT);
+
+  const user = await authenticationMiddlewareSocketIO(authJWT, true);
 
   const { experimentId } = message;
   const statusRes = await getPipelineStatus(experimentId, process);

tests/utils/hookRunner.test.js

@@ -99,4 +99,18 @@ describe('HookRunner', () => {
     expect(runner.results['event-2']).toEqual([fn1()]);
     expect(runner.results['event-3']).toEqual([fn1()]);
   });
+
+  it('does not crash when a hook throws an exception ', async () => {
+    const fn1 = jest.fn(() => { throw new Error(); });
+
+    const runner = new HookRunner();
+
+    runner.registerAll([fn1]);
+
+    await runner.run({ taskName: 'event-1' });
+
+    expect(fn1).toHaveBeenCalledTimes(1);
+    // functions that throw exceptions return an empty list
+    expect(runner.results['event-1']).toEqual([]);
+  });
 });