Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIR 1384 #76

Merged
merged 4 commits into from
Jan 5, 2024
Merged

CIR 1384 #76

merged 4 commits into from
Jan 5, 2024

Conversation

ssaleem-ee
Copy link
Contributor

  • CIR-1384: Play3 upgrade.
  • CIR-1384: Some code cleanup

@platops-pr-bot
Copy link

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.18.0 in project/plugins.sbt
  • Config key auditing.traceRequests can be removed from conf/application.conf. It has been unused since play-auditing:3.0.0
  • Config key play.application.loader can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key play.http.requestHandler can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.name can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.rateUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.durationUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.showSamples can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.jvm can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.audit.AuditModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.graphite.GraphiteMetricsModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.backend.BackendModule can be removed from conf/application.conf. This is already provided by Bootstrap

@platops-pr-bot
Copy link

  • Config key auditing.traceRequests can be removed from conf/application.conf. It has been unused since play-auditing:3.0.0
  • Config key play.application.loader can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key play.http.requestHandler can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.name can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.rateUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.durationUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.showSamples can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.jvm can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.audit.AuditModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.graphite.GraphiteMetricsModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.backend.BackendModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.18.0 in project/plugins.sbt

@platops-pr-bot
Copy link

  • Config key auditing.traceRequests can be removed from conf/application.conf. It has been unused since play-auditing:3.0.0
  • Config key play.application.loader can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key play.http.requestHandler can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.name can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.rateUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.durationUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.showSamples can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.jvm can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.audit.AuditModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.graphite.GraphiteMetricsModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.backend.BackendModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.18.0 in project/plugins.sbt

@ssaleem-ee ssaleem-ee marked this pull request as ready for review January 3, 2024 14:12
@ssaleem-ee ssaleem-ee marked this pull request as draft January 4, 2024 09:24
@ssaleem-ee ssaleem-ee marked this pull request as ready for review January 5, 2024 07:56
@beyond-code-github beyond-code-github merged commit 0b126d3 into main Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssaleem-ee @platops-pr-bot @beyond-code-github