-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies and switch from alga to simba #2
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please also bump the minor version of this package to 0.15.
stl_io = "0.5" | ||
bbox = "0.11" | ||
num-traits = "0.2" | ||
bbox = "0.11.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't just major+minor be fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using the default conventions of the cargo-edit
tool which was what I used to automate this change. I suppose it might help ensure that users of this crate get at least the version of a dependency that was used to run the test suite. Imagine if 0.5.2
is buggy, 0.5.3
is fine, and the tests of this crate were tested against 0.5.3
. Setting the patch version ensures that users don't accidentally get the 0.5.2
version (ie. they get at least the version that this crate was tested against).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build currently fails with this PR. Can you please take a look? |
Hey! I'll work on fixing the PR! It would help a little bit if the new |
The issue is that the normal The fix is to remove the patch and select |
The
alga
crate is deprecated and has been replaced bysimba
. This PR also allows the introduction of a much newernalgebra
version which is pretty significant.Depends on hmeyer/bbox#3 for now, after which the
[patch]
section will be removed