DTSPO-8837 - Azurerm v3 provider backend app gw #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endakelly
requested review from
kunlebalogun,
darren221980,
staceywilson and
a team
timja
reviewed
Jun 16, 2022
| @@ -11,25 +11,33 @@ gateways: | |||
| # Toffee application | |||
| - product: toffee | |||
| component: recipe-backend | |||
| priority: 10 | |||
There was a problem hiding this comment.
This has to be set in the latest azurerm api for some reason. In previous versions this is set automatically but now it has to be done manually. Haven't yet figured out how to generate the figure dynamically so it doesn't need to be coded in the vars
hashicorp/terraform-provider-azurerm#17079
There was a problem hiding this comment.
is there some way to get an index and then add 10?
There was a problem hiding this comment.
Matt sent me a code snippet that I'm going to look to adapt for this
timja
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DTSPO-8837
Change description
Use azurerm v3 provider for backend app gw
Once azure-platform-terraform repo has also been updated, the branches on the modules will be merged to master and the references to them in this repo will be reverted to master.
Does this PR introduce a breaking change? (check one with "x")