Dtspo 13916 terraform format implementation #1106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomast1906
reviewed
Jul 17, 2023
…AT-IMPLEMENTATION add master changes
updating with chanages to master
…AT-IMPLEMENTATION uodating master changes
…AT-IMPLEMENTATION updating master changes
…AT-IMPLEMENTATION merge master changes
timja
reviewed
Oct 27, 2023
vars/spinInfra.groovy
Outdated
Comment on lines
12
to
14
| USER_NAME=${1} | ||
| BEARER_TOKEN=${2} | ||
| EMAIL_ID=${3} |
There was a problem hiding this comment.
what's this? it will be breaking it
timja
reviewed
Oct 27, 2023
vars/spinInfra.groovy
Outdated
| sh 'terraform fmt -recursive' | ||
|
|
||
| // Commit the formatting changes | ||
| git fetch origin $BRANCH:$BRANCH |
There was a problem hiding this comment.
this needs to be in an sh step
vars/spinInfra.groovy
Outdated
| git fetch origin $BRANCH:$BRANCH | ||
| sh 'git remote set-url origin $(git config remote.origin.url | sed "s/github.com/${USER_NAME}:${BEARER_TOKEN}@github.com/g ")' | ||
|
|
||
| sh "git config --global user.name ${USER_NAME}:" |
There was a problem hiding this comment.
all these sh steps should be combined into one and they probably should be in an external script in the resources folder, see an example:
adding changes from master
adding changes from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # . (This is applicable only if this pull request relates to a GitHub issue, delete the line otherwise)
Notes:
https://tools.hmcts.net/jira/browse/DTSPO-13916
Adding a auto terraform formatting updater for branches and warning message.