Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt fix to id not found error #266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

reespozzi
Copy link
Contributor

@reespozzi reespozzi commented Dec 2, 2024

This is in place in a few other functions, maybe there is an issue where an id is not returned, this is not being handled properly currently by this function
Current error is:

TypeError: Cannot read properties of undefined (reading 'id')
    at getEntraGroupId (file:///tmp/xfs-b6d5b6c5/dlx-1738/.yarn/cache/azure-app-proxy-manager-npm-1.2.11-70f78853e3-e5d607ead2.zip/node_modules/azure-app-proxy-manager/lib/servicePrincipalManager.js:65:26)

For example: https://github.com/hmcts/azure-app-proxy-manager/blob/main/src/servicePrincipalManager.ts#L74-L77

This is in place in a few other functions, maybe there is an issue where an id is not returned, this is not being handled properly currently by this function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant