feat: improve default app bar layout #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hm21
approved these changes
Nov 5, 2024
|
Thank you for your pull request. I’ve accepted it and made a minor adjustment to the padding for the loading indicator to prevent layout shifts when the editor is initialized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR aims to slightly improve the default app bar's layout. Specifically, its actions.
I moved the close action to the AppBar's
leadingparameter.I removed the padding from the IconButtons, since the default one provides a more rounded padding (instead of just horizontal padding, we have all around 8 points)
I changed the padding of the loading indicator to be a multiple of 2, since most design systems work with even numbers.