Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right overflow on paint validator #177

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Right overflow on paint validator #177

merged 3 commits into from
Jul 30, 2024

Conversation

HeropolisDa2ny
Copy link
Contributor

@HeropolisDa2ny HeropolisDa2ny commented Jul 29, 2024

The middle Spacer is used for a long width screen to have the configs aligned in the middle instead of having it aligned on the right side. This configuration might be coherent only when the screen width is big enough (for tablets).

This is the rendering with a width < 640 px (640 being the ~max width of a phone).

Screenshot 2024-07-29 at 8 38 45

By removing the fix width of 80px it remove the overflow error

Copy link
Owner

@hm21 hm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, this will fix that issue. The hardcoded 80px space was needed a long time ago as there was only one action button to center that button, but since we have a lot of action buttons it makes more sense to align everything as you do on the right side.

@hm21 hm21 merged commit 24748f4 into hm21:stable Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants