Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: button overflowing #173

Closed
HeropolisDa2ny opened this issue Jul 26, 2024 · 5 comments
Closed

[Bug]: button overflowing #173

HeropolisDa2ny opened this issue Jul 26, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@HeropolisDa2ny
Copy link
Contributor

HeropolisDa2ny commented Jul 26, 2024

Package Version

4.3.0

Flutter Version

3.22.3

Platforms

Android

How to reproduce?

With ProImageEditor.memory, select the paint option.
The top bar will have a right overflowing icon.

Screenshot 2024-07-26 at 8 57 49

Logs (optional)

No response

Example code (optional)

No response

Device Model (optional)

No response

@HeropolisDa2ny HeropolisDa2ny added the bug Something isn't working label Jul 26, 2024
@hm21
Copy link
Owner

hm21 commented Jul 27, 2024

I just tried it on Android but in my case everything works fine. Can you try if you have this issue as well when you remove all configs from the image editor? And if yes, can you fork the sample code and try if it works as correct? This will help to check if the problem is on your code, a specific device or some configuration on the editor.

@HeropolisDa2ny
Copy link
Contributor Author

HeropolisDa2ny commented Jul 29, 2024

I just tried it on Android but in my case everything works fine. Can you try if you have this issue as well when you remove all configs from the image editor? And if yes, can you fork the sample code and try if it works as correct? This will help to check if the problem is on your code, a specific device or some configuration on the editor.

Here's my code without anything but the image :

return ProImageEditor.memory(
  image,
  callbacks: ProImageEditorCallbacks(
    onImageEditingComplete: (bytes) async {},
    onCloseEditor: () {},
  ),
  // configs: configs,
);

Here's the different tabs :

Screenshot 2024-07-29 at 8 06 17 Screenshot 2024-07-29 at 8 06 42 Screenshot 2024-07-29 at 8 06 50 Screenshot 2024-07-29 at 8 07 03 Screenshot 2024-07-29 at 8 07 11

Here's the details of my emulator :

Screenshot 2024-07-29 at 8 11 32

@HeropolisDa2ny
Copy link
Contributor Author

HeropolisDa2ny commented Jul 29, 2024

I made a PR to resolve the problem : #177 but it includes spacing modification.

@hm21
Copy link
Owner

hm21 commented Jul 30, 2024

Great job, I just merged it and will release the new version.

@hm21 hm21 closed this as completed Jul 30, 2024
@HeropolisDa2ny
Copy link
Contributor Author

HeropolisDa2ny commented Jul 30, 2024

@hm21
Here another overflowing fix : #178 it includes agencement modifications and an add of option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants