Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove vertical scroll in the carousel #7

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: remove vertical scroll in the carousel #7

merged 1 commit into from
Feb 16, 2023

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Feb 14, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 14, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 14, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@davidnuescheler
Copy link
Contributor

thanks so much... this was super annoying. thanks for the fix.

@buuhuu buuhuu merged commit faacefe into main Feb 16, 2023
iuliag added a commit that referenced this pull request Aug 23, 2023
@iuliag
Squashed 'plugins/rum-conversion/' changes from 9dd77bb..c146fce
c483117 
c146fce feat(omnivore): Add conversion tracking data attribute to tracked elements (#7)
c70885a Update README.md (#5)

git-subtree-dir: plugins/rum-conversion
git-subtree-split: c146fce535b26a9a88925cfeaa742da8f5dcf55f
ilievlad73 added a commit to ilievlad73/wknd that referenced this pull request Oct 31, 2023
@ilievlad73
Squashed 'plugins/experience-decisioning/' changes from be2e07d..effa50e
dbaf8c6 
effa50e feat: expose the served url in the respective apis (hlxsites#8)
5706df2 doc: update readme
fc522cd fix(fullExperiment): replaceInner page index (hlxsites#7)
f3d6de1 chore: rename the plugin for GA (hlxsites#5)
84444c7 chore: rename the plugin for GA (hlxsites#4)

git-subtree-dir: plugins/experience-decisioning
git-subtree-split: effa50e9905c53d8bc6b99c54277b4f412607af8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnuescheler davidnuescheler davidnuescheler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buuhuu @davidnuescheler