Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color reset if both columns contain differences #4

Closed
nicoddemus opened this issue Aug 9, 2018 · 2 comments
Closed

Color reset if both columns contain differences #4

nicoddemus opened this issue Aug 9, 2018 · 2 comments

Comments

@nicoddemus
Copy link
Contributor

Hi,

First of all congratulations on the new plugin!

I took it for a spin and in general it works great, I've found that when there's a difference in both sides of the diff the color is reset to white in some places:

color-diff

It seems only the X and i characters in Xforce and iforce should be in yellow and the rest in red, to highlight the difference?

I'm using the code from one of your tests, slightly modfied:

def test():

    one = {
        'currency': 'USD',
        'default_UK_warehouse': 'Xforce',
        'default_incoterm': 'EXW',
        'name': 'John Doe',
        'payment_term': '30% deposit, 70% balance',
        'reference': '42551456-a1b3-49bd-beed-b168d9a5ac83',
        'website': 'http://megasofas.example.com',
        'main_contact': {
            'city': 'Madeira',
            'country': 'PT',
            'email': '[email protected]',
            'fax': '012356 789039',
            'mobile': '012356 789039',
            'name': 'Almeida & Filhos - Example, S.A.',
            'phone': '253444802010',
            'postcode': '4815-123',
            'street': "Senhora Test D'Ajuda, 432",
            'street2': 'Moreira de Conegos'
        },
    }
    two = {
        'currency': 'USD',
        'default_UK_warehouse': 'iforce',
        'default_incoterm': 'EXW',
        'freight_forwarder': 'flexport',
        'name': 'John Doe',
        'payment_term': '30% deposit, 70% balance',
        'reference': '42551456-a1b3-49bd-beed-b168d9a5ac83',
        'website': 'http://megasofas.example.com',
        'main_contact': {
            'name': 'Almeida & Filhos - Example, S.A.',
            'email': '[email protected]',
            'street': "Senhora Test D'Ajuda, 432",
            'street2': 'Moreira de Conegos',
            'postcode': '4815-123',
            'city': 'Madeira',
            'country': 'PT',
            'phone': '253444802010',
            'fax': '012356 789039',
            'mobile': '012356 789039'
        }
    }

    assert one == two

Thanks!

@hjwp
Copy link
Owner

hjwp commented Aug 9, 2018

thanks! will take a look...

@nicoddemus
Copy link
Contributor Author

Awesome! 😁

untitled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants