Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/graal updates #140

Closed
wants to merge 3 commits into from
Closed

Fix/graal updates #140

wants to merge 3 commits into from

Conversation

sbaier1
Copy link

@sbaier1 sbaier1 commented Mar 18, 2020

Motivation

nativeImage gradle task does currently doesn't produce a working image

Changes

  • update graalVM to the latest compatible version
  • update picoCLI
  • update jline
  • update & fix reflection config generation
  • filter out erroneous reflection mappings automatically

This produces a build with working shell & command line parameters again, as far as i can tell

OUT OF SCOPE

TLS support, need to wait for graal plugin to be updated to in order to update the build to graalVM 20.
(which we should definitely do ASAP afterwards)

@sbaier1 sbaier1 requested a review from gitseti as a code owner March 18, 2020 16:10
@cla-bot
Copy link

cla-bot bot commented Mar 18, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anja Helmbrecht-Schaar.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails


@SuppressWarnings("NullableProblems")
@CommandLine.Spec
private @NotNull CommandLine.Model.CommandSpec spec;

public ShellCommand() {
Copy link
Author

@sbaier1 sbaier1 Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explanation: PicoCLIs ReflectionConfigGenerator will throw an exception if there is no default constructor. not sure if more changes are necessary here.
(the build works as it stands, but i don't know if the properties field not being final anymore is a problem)

@sbaier1 sbaier1 force-pushed the fix/graal-updates branch from e8559f1 to 5121af3 Compare March 18, 2020 16:18
@cla-bot cla-bot bot added the cla-signed label Mar 18, 2020
@sbaier1 sbaier1 mentioned this pull request Mar 20, 2020
4 tasks
@sbaier1
Copy link
Author

sbaier1 commented Mar 30, 2020

Closing until further notice because further improvements are necessary, tracked in #141 .

@sbaier1 sbaier1 closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant