-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for Mqtt5BlockingClient #637
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @tejas-n on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @tejas-n on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @tejas-n on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Hi @tejas-n, our internal CLA tooling was broken for a little while, sorry for that. |
@sauroter No worries. I've signed the CLA. |
Description
The official GitHub pages do a great job of explaining the exceptions that would be thrown by
connect(Mqtt5Connect)
andpublish(Mqtt5Publish)
, but the Javadocs miss mentioning a couple of them, which can lead to the developers not handling them. I'm just using the exception description as already defined on https://hivemq.github.io/hivemq-mqtt-client/docs/mqtt-operations/Type of Change
Checklist