Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Mqtt5BlockingClient #637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tejas-n
Copy link

@tejas-n tejas-n commented Aug 12, 2024

Description

The official GitHub pages do a great job of explaining the exceptions that would be thrown by connect(Mqtt5Connect) and publish(Mqtt5Publish), but the Javadocs miss mentioning a couple of them, which can lead to the developers not handling them. I'm just using the exception description as already defined on https://hivemq.github.io/hivemq-mqtt-client/docs/mqtt-operations/

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created.
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

Copy link

cla-bot bot commented Aug 12, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @tejas-n on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

Copy link

cla-bot bot commented Aug 12, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @tejas-n on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

Copy link

cla-bot bot commented Aug 12, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @tejas-n on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@sauroter
Copy link
Member

sauroter commented Sep 9, 2024

@cla-bot check

Copy link

cla-bot bot commented Sep 9, 2024

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Sep 9, 2024
@sauroter
Copy link
Member

sauroter commented Sep 9, 2024

Hi @tejas-n,

our internal CLA tooling was broken for a little while, sorry for that.

@tejas-n
Copy link
Author

tejas-n commented Sep 25, 2024

@sauroter No worries. I've signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants