Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(94): Connection Status are now updated on the workspace #98

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Sep 11, 2023

Fixes #94

The PR corrects one missed feature from the workspace, the ability to regularly check for and update the connection status of bridges and adapters.

Both API requests are handled together, updating the list of nodes when necessary.

Note that, by nature of the existing API endpoints, we need to send 2 requests for every update.

Out of scope

  • The ability to start and stop adapters or bridges will be done in a subsequent ticket

@vanch3d vanch3d requested review from sfrehse and simon622 September 11, 2023 09:17
@vanch3d vanch3d self-assigned this Sep 11, 2023
Copy link
Contributor

@sfrehse sfrehse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
]

describe('updateNodeStatus', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@simon622 simon622 merged commit b71372e into master Sep 11, 2023
@simon622 simon622 deleted the fix/94/workspace-connection-status branch September 11, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[workspace] Connection status is not polling for update
3 participants