Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(28933): Add device tags to the node visualisation #730

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Jan 6, 2025

See https://hivemq.kanbanize.com/ctrl_board/57/cards/28933/details/

The PR fixes a glaring gap. Device tags are now rendered on the device node, similar to how topic filters and topics are shown on the adapters.

The PR also improves the layout of the device node

Out-of-scope

  • The "glued" relation between a device and its adapter adapter is rendered by a fixed distance between the two nodes, from top to top. The distance reflects the gap needed to render two tags in the device node. The layout should be more dynamic, by having a constant length of the link between the two nodes, i.e. from bottom to top. This will be done in a subsequent ticket

Before

screenshot-localhost_3000-2025_01_06-19_24_56

After

screenshot-localhost_3000-2025_01_06-19_30_10

@vanch3d vanch3d self-assigned this Jan 6, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 6, 2025
@vanch3d vanch3d requested a review from sfrehse January 8, 2025 16:44
Copy link
Contributor

@oli-hivemq oli-hivemq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be interested in having a visual designer propose a few tweaks to the styling, but otherwise it looks good to me 🦣

@vanch3d vanch3d force-pushed the fix/28933/device-tag-node branch from 3f328cc to da9590d Compare January 10, 2025 12:13
@vanch3d vanch3d merged commit 1d0f150 into master Jan 10, 2025
10 checks passed
@vanch3d vanch3d deleted the fix/28933/device-tag-node branch January 10, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants