refactor(28703): Add the source of a side panel into its header #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfrehse
approved these changes
Dec 16, 2024
vanch3d
force-pushed
the
refactor/28703/workspace-form-headers
branch
from
65db3c1 to
b905161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/28703/details/
The PR fixes a significant usability issue, whereas most of the side panels opening in the workspace would not mention which node or link would have triggered the opening.
The side panels now contain a cartouche in the header which will indicate which content is associated with the specific instance of the panel.
The content of that cartouche has been normalised to render the icon of the entity, its name and its description.
Note that, in most cases, the trigger of the side panel will be one of the nodes on the workspace (or a link connecting them). The cartouche therefore refers to these nodes, which might reinforce a somehow loose coupling (e.g.
topic filtersbeing located within theEdgenode)Before
After