Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(28701): fix style of folder array items when error #706

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Dec 16, 2024

See https://hivemq.kanbanize.com/ctrl_board/57/cards/28701/details/

The PR fixes a major usability issue, by styling array items with the common "red" border when a validation error is generated but the item is "folded" and doesn't materialise the error

Before

screenshot-localhost_3000-2024_12_16-07_58_51

After

screenshot-localhost_3000-2024_12_16-07_57_54

@vanch3d vanch3d self-assigned this Dec 16, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 16, 2024
@vanch3d vanch3d marked this pull request as ready for review December 16, 2024 09:15
@vanch3d vanch3d force-pushed the fix/28701/error-folded-items branch from db72c2d to 6bd9f6d Compare December 16, 2024 14:17
@vanch3d vanch3d merged commit e726774 into master Dec 16, 2024
9 of 10 checks passed
@vanch3d vanch3d deleted the fix/28701/error-folded-items branch December 16, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants