-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(28664): Add schema management for the topic filters #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
force-pushed
the
feat/28664/schema-topic-filter
branch
from
December 9, 2024 15:53
c12f21c
to
1007b0a
Compare
estefania-hivemq
approved these changes
Dec 10, 2024
- change the order of the tabs - reorganise the status messages
vanch3d
force-pushed
the
feat/28664/schema-topic-filter
branch
from
December 10, 2024 16:37
772bfbf
to
6700288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/28664/details/
This PR creates a new UX for managing the schema associated with topic filters. It refactors the secondary editor flow in the main list of topic filters (accessible through the "manage schema" CTA on every item).
The flow is based on three distinct operations:
The three operations are rendered in tabs on a dedicated side panel.
Out-of-scope
properties
are not even a mandatory part of the schema. The basic validation (RJSF
+AJV
) will only address structural errors (e.g. wrong JSON). Custom rules and restrictions on acceptable schemas should be considered.data-url
bundle (https://www.rfc-editor.org/rfc/rfc2397) and is stored as such with its topic filter. This assumption might have to be reassessedPUT
request. TheGET
cache is therefore updated and theReact
lifecycle automatically updates the DOM. The result is that the schema editor is closed abruptly. This behaviour might be considered too brusque for a proper UX and will be looked at in the subsequent ticketBefore
After