Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(27975): tag uniqueness and other validation updates #677

Merged
merged 17 commits into from
Dec 9, 2024

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Dec 6, 2024

See https://hivemq.kanbanize.com/ctrl_board/57/cards/27975/details/

This PR adds client-side validation for device tags, ensuring they are unique per device but also across the Edge instance.

The PR also re-introduces other validations that wehnt missing due to the refactoring

  • tag, topic and topic filter names are validated on input
  • tag and topic filter references are through a select widget only (with options provided from list of candidates, no creation allowed)
  • topic references is provided through the select widget that allows creation

Before

screenshot-localhost_3000-2024_12_09-09_23_49
screenshot-localhost_3000-2024_12_09-09_24_19
screenshot-localhost_3000-2024_12_09-09_24_41

After

screenshot-localhost_3000-2024_12_09-09_25_56
screenshot-localhost_3000-2024_12_09-09_27_26
screenshot-localhost_3000-2024_12_09-09_28_04

@vanch3d vanch3d self-assigned this Dec 6, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 6, 2024
@vanch3d vanch3d marked this pull request as draft December 6, 2024 10:46
@vanch3d vanch3d marked this pull request as ready for review December 6, 2024 22:19
@vanch3d vanch3d force-pushed the feat/27975/validations branch from 96cc792 to e55d697 Compare December 9, 2024 09:35
@vanch3d vanch3d merged commit 39d401f into master Dec 9, 2024
10 checks passed
@vanch3d vanch3d deleted the feat/27975/validations branch December 9, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants