-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(26339): Improve errors display in RJSF forms and handle focus on hidden widget #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
force-pushed
the
feat/26339/error-focus
branch
from
November 18, 2024 16:23
da63770
to
558a9e4
Compare
- change layout of error items - add link for tabs and field
vanch3d
force-pushed
the
feat/26339/error-focus
branch
from
November 20, 2024 08:19
558a9e4
to
52d0add
Compare
oli-hivemq
reviewed
Nov 21, 2024
oli-hivemq
reviewed
Nov 21, 2024
hivemq-edge/src/frontend/src/components/rjsf/Form/error-focus.utils.ts
Outdated
Show resolved
Hide resolved
oli-hivemq
reviewed
Nov 21, 2024
hivemq-edge/src/frontend/src/components/rjsf/Form/error-focus.utils.ts
Outdated
Show resolved
Hide resolved
oli-hivemq
reviewed
Nov 21, 2024
oli-hivemq
reviewed
Nov 21, 2024
hivemq-edge/src/frontend/src/components/rjsf/Form/error-focus.utils.ts
Outdated
Show resolved
Hide resolved
oli-hivemq
reviewed
Nov 21, 2024
hivemq-edge/src/frontend/src/components/rjsf/Form/error-focus.utils.ts
Outdated
Show resolved
Hide resolved
oli-hivemq
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major but I left a few comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/26339/details/
The PR significantly improves the rendering of the error summary in all the RJSF-based forms. The main problem was error messages mentioning an input field that might be on a grouping tab not currently active or within a "collapsed" item in an array. In such situations, not only would the field with the property not be visible to the users, but its location would not even be mentioned.
Design
Out-of-scope
Before
After